Added support for serialization and deserialization of 'object' to static code generation #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atic code generation.
EdwardCooke
reviewed
Oct 6, 2023
|
Sorry it’s taking so long. Work emergency. It may not be until tomorrow I get to look at this. |
|
Just waiting for the build to complete and I'll get a release out |
|
This feature has been released in version 13.7.0. |
|
Thanks for having this merged. The code generation should be much more usable now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for serialization and deserialization of 'object' as long as the type is a primitive type or is known to the static context.
Changes:
IsKnownType()method to theStaticContextto determine whether a type is known to the context.StaticTypeResolverwhich resolves types known the context.StaticTypeDescriptorto use theStaticTypeResolverfrom the context.@EdwardCooke What do you think ? If the approach is fine I will create an issue to reference this PR.