-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code generation for Dictionary and List which use Array values #855
Fix code generation for Dictionary and List which use Array values #855
Conversation
@EdwardCooke I have another fix for static code generation prepared, so please do not do a release immediately ;) |
Sounds good. I’ll try and get to it as soon as your ready. |
Should I put the fix in this PR or do another one ? |
It doesn’t always go into a dictionary. You can serialize/deserialize just a single value like an int or string. Also, you won’t know what the type of the object should be so it doesn’t know what to deserialize into which is why it throws an exception there. There was another case where it couldn’t figure it out back when I built out the static stuff and I can’t remember exactly what it is. I very vaguely remember it had something to do with dictionary object, object not working right in aot compiled applications. Might be way off there though. did you find a way around those object limits? |
At least I managed to deserialize object into Dictionary<object,object> with AOT. I will open annother issue about that, this PR doesnt seem to be the right place to discuss this. :) |
Sounds good to me. Do you want me to merge this in then? |
Yes please. |
Will do |
This feature has been released in version 13.5.2. |
Fixes #854