Implement DateOnly and TimeOnly converters. #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdwardCooke
reviewed
Aug 28, 2023
|
Just waiting for the build to complete and I'll get a release out |
|
This feature has been released in version 13.7.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since .NET 6 there are two new types available for dates and times:
DateOnlyandTimeOnly. These new converters supplement the existingDateTimeConverter.The unit tests are based on
DateTimeConverterTests. Some tests were removed because they usedDateTimeKindand were identical to other tests after removing all irrelevant code. Some test cases using date/time formats were removed because they made no sense in that context, or because the formats are explicitly unsupported (i.e. throwing an exception) forDateOnlyorTimeOnly.The commented-out test cases fail, just like they do in
DateTimeConverterTests. I'm not entirely sure why the various date/time format test cases exist, since they do not test additional code paths. But I've left them in for consistency.