Issue #935

[bafinouri91]

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #<issue_no>

Type of change

Delete unchecked boxes (only for Type of change)

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Development Configuration
Type "flutter --version" and "dart --version" in your CMD to check versions.

• Flutter version:
• Dart version:

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas, if necessary
• I have made corresponding changes to the documentation, if necessary
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works, if necessary
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have Acceptance Tested this on an iOS device
• I have Acceptance Tested this on an Android device

[codecov]

Codecov Report

Merging #956 (93828ff) into develop (70bb646) will decrease coverage by 0.8%.
Report is 2 commits behind head on develop.
The diff coverage is 86.6%.

❗ Current head 93828ff differs from pull request most recent head 22996b6. Consider uploading reports for the commit 22996b6 to get more accurate results

Additional details and impacted files

@@            Coverage Diff            @@
##           develop    #956     +/-   ##
=========================================
- Coverage     79.2%   78.5%   -0.8%     
=========================================
  Files           84      86      +2     
  Lines         4846    4991    +145     
=========================================
+ Hits          3841    3918     +77     
- Misses        1005    1073     +68     

Files	Coverage Δ
...widgets/weekplan_screen_widgets/activity_card.dart	96.2% <86.6%> (-1.6%)	⬇️

... and 7 files with indirect coverage changes

[JMyrtue]

Our group have now reviewed this pull request, and found a single concern.

The issue specifies that the guardians profile picture should be hidden on choice boards, however, we found that it was also hidden for the citizen on regular activities. From our understanding the issue does not intend for the feature to be removed, as it specifies that "possible suggested solution: possibly hide the profile picture on choice boards". Furthermore, from the meeting with the stakeholder we got the impression that it is an intended feature that citizens should be able to see what guardian is associated to an activity.

To explicitly specify, the above image is provided: in this pull request both profile images are removed, while we only expect the one indicated by the green arrow to be removed.

Finally, the documentation on this commit is lackluster as it does not provide any information on the pull request.

Accordingly, we do not see this request fit for merge in its current state.

[bafinouri91]

Thanks for the feedback, we are looking into it with our PO.