Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing on Mondays #936

Open
emilnormann opened this issue Dec 6, 2022 · 2 comments · May be fixed by #973
Open

Tests failing on Mondays #936

emilnormann opened this issue Dec 6, 2022 · 2 comments · May be fixed by #973
Assignees
Labels
Developer Issues which the developers are concerned about, usually not something the users know about Good First Issue Usually small issues which does not take long to fix Priority: high High priority, its required to work Type: bug Bugs and other insects

Comments

@emilnormann
Copy link
Contributor

Description

When running tests on Mondays or when system time is set to a Monday the following tests fail:
image

This also affects Github Actions so pull requests made on Mondays will fail Actions.
To Reproduce
Steps to reproduce the behavior:

  1. Have system time set for a Monday
  2. Run tests
    Observe that the specified tests fail

Expected behavior
For tests to pass or at least achieve same behavior as on other days.

@emilnormann emilnormann added Type: bug Bugs and other insects Priority: high High priority, its required to work Developer Issues which the developers are concerned about, usually not something the users know about labels Dec 6, 2022
@emilnormann emilnormann changed the title Tests failing on mondays Tests failing on Mondays Dec 6, 2022
@emilnormann emilnormann added the Good First Issue Usually small issues which does not take long to fix label Dec 8, 2022
@JakobTopholt
Copy link
Contributor

Truly a Giraf issue for the future Giraf Calves to fix

@SadAndBroken
Copy link
Contributor

Dette er essentielt en ikke fejl. Grunden til at dette bliver anset for at være en fejl, stammer fra at mockWeek.days kun har de 7 uge dage at arbejde med. I testene bruges mandag som et eksempel, hvor nogle informationer bliver gemt under denne dag. Problemet bliver skabt når den nuværende dag, altså dags dato, er den samme dag grundet activity_card.dart. Her bruges et switch statement til at udføre funktionalitet på kort, alt efter deres state. Hvis deres state er "Normal" bliver den nødvendige funktionallitet for testene udføre som det skal, men hvis stated er "aktiv" vil det ikke. Problemet er, at hvis i dag er en mandag, bliver mockWeek.days[0] anset for at være aktiv, i stedet for normal.

Dette er blevet testet ved at ændre mockWeek.days[0] til mockWeek.days[1], og ændre dagen til tirsdag, hvor samme fejl viser sig.

Image

Image

@SadAndBroken SadAndBroken linked a pull request Nov 17, 2023 that will close this issue
SadAndBroken added a commit that referenced this issue Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Issues which the developers are concerned about, usually not something the users know about Good First Issue Usually small issues which does not take long to fix Priority: high High priority, its required to work Type: bug Bugs and other insects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants