Skip to content

Commit

Permalink
Merge branch 'DottePictogramBlocTestTodoFix' into TestsRevisited
Browse files Browse the repository at this point in the history
  • Loading branch information
Undersnyfler committed Dec 4, 2023
2 parents 0e2ce8c + f816fcb commit 68b573d
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion test/blocs/pictogram_bloc_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,12 @@ void main() {
bloc.search(query);
}));

// TODO: Is this even a valid test?
/*Closes streams for the pictogram bloc
test does not return anything on its own (see lack of expect function)
but the dispose function should throw an error if something goes wrong within
itself. It may however still be relevant to keep this test as it ensures the
streams are actually closed at the end of the test file.
*/
test('Should dispose stream', async((DoneFn done) {
bloc.pictograms.listen((_) {}, onDone: done);
bloc.dispose();
Expand Down

0 comments on commit 68b573d

Please sign in to comment.