Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading sector tag #813

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Fix reading sector tag #813

merged 1 commit into from
Aug 5, 2023

Conversation

FakeShemp
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New filesystem, test images in [url]
  • New media image, test images in [url]
  • New partition scheme, test images in [url]
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Please check this carefully, but I think this bugfix is correct.

Previous code read at wrong offset when reading a sector tag from aaruf from a buffer storing multiple tags in sequence, like the CPR_MAI on DVDs and CD subchannels.

As far as I know nothing was actually affected since subchannels on CDs were always read in ReadSectorLong and no other format handled the CPR_MAI. CD subchannels could be affected though.

@claunia claunia merged commit d1d9e08 into devel Aug 5, 2023
@claunia
Copy link
Collaborator

claunia commented Aug 5, 2023

Subchannels are not affected because sector_offset is always 0 with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants