Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught Error: No protocol method IDOMImage.-get-dom-image defined for type #50

Open
pkobrien opened this issue Jun 26, 2015 · 2 comments

Comments

@pkobrien
Copy link

For objects that are missing this protocol method, would it make sense for freactive to wrap them in a (str foo) call? That would save one from having to do that for cases like this one:

    [:p "Date/Time " (str (goog.date.DateTime.))]
@aaronc
Copy link
Owner

aaronc commented Jun 26, 2015

Yes, I agree this should be default. Although usually for dates you should
have some locale formatting - with IDOMImage a custom rendering could be
providing by extending the protocol.

On Fri, Jun 26, 2015 at 9:24 AM, pkobrien [email protected] wrote:

For objects that are missing this protocol method, would it make sense for
freactive to wrap them in a (str foo) call? That would save one from having
to do that for cases like this one:

[:p "Date/Time " (str (goog.date.DateTime.))]


Reply to this email directly or view it on GitHub
#50.

@pkobrien
Copy link
Author

I agree that extending a protocol is a viable option, and that there might be a need for special formatting. However, at this point I keep running into this error when I just want to throw a value into an element and display it in the browser. Sometimes it works, sometimes it doesn't. So it would be nice to have a default str wrapper. Which doesn't stop me from extending a protocol in the future in cases where that makes sense to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants