Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error on windows #160

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

tobil4sk
Copy link
Contributor

@tobil4sk tobil4sk commented Sep 4, 2024

Fixes this error:

# [...]
# 100 | (rule
# 101 |  (targets generate_types_step_2.exe)
# 102 |  (deps (:c generate_types_step_2.c) helpers.h shims.h)
# .....
# 112 |     -I %{ocaml_where} \
# 113 |     -I . -o %{targets}; \
# 114 |   fi")))
# (cd _build/default/src/c && C:\msys64\usr\bin\bash.exe -e -u -o pipefail -c "if [ 'cc' = 'msvc' ]; then gcc -O2 -fno-strict-aliasing -fwrapv -mms-bitfields generate_types_step_2.c -I 'C:\...\opam\default\lib\ctypes' -I C:\...\opam\default/lib/ocaml -I . /Fe\"generate_types_step_2.exe\"; else gcc -O2 -fno-strict-aliasing -fwrapv -mms-bitfields genera[...]
# generate_types_step_2.c:3:10: fatal error: caml/mlvalues.h: No such file or directory
#     3 | #include <caml/mlvalues.h>
#       |          ^~~~~~~~~~~~~~~~~
# compilation terminated.

The quotes ensure that the include path is interpreted correctly.

@tobil4sk
Copy link
Contributor Author

tobil4sk commented Sep 4, 2024

Failure seems related to #159.

@aantron aantron merged commit ae9ee9b into aantron:master Sep 4, 2024
5 of 6 checks passed
@aantron
Copy link
Owner

aantron commented Sep 4, 2024

Thank you!

@tobil4sk tobil4sk deleted the fix/windows-build branch September 4, 2024 18:53
@tobil4sk
Copy link
Contributor Author

tobil4sk commented Sep 4, 2024

Thanks!

@aantron
Copy link
Owner

aantron commented Sep 5, 2024

Let me know if you'd like a release to opam.

@tobil4sk
Copy link
Contributor Author

tobil4sk commented Sep 5, 2024

A release with this patch and 821bc0b would be useful, if it's not too much trouble! :) Thanks

@aantron
Copy link
Owner

aantron commented Sep 5, 2024

ocaml/opam-repository#26501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants