Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore Luv - Unix.file_descr conversions, this time in a separate helper package #90

Closed
aantron opened this issue Jan 14, 2021 · 1 comment
Closed

Restore Luv - Unix.file_descr conversions, this time in a separate helper package #90

aantron opened this issue Jan 14, 2021 · 1 comment

Comments

@aantron
Copy link
Owner

aantron commented Jan 14, 2021

Needed for the Lwt libuv port (ocsigen/lwt#813).
@aantron
Copy link
Owner Author

aantron commented Jan 14, 2021

The commit that originally removed them: 705ec14

@aantron aantron mentioned this issue Jan 14, 2021
Open
2 tasks
aantron added a commit that referenced this issue Jan 14, 2021
@aantron
Restore conversions between libuv and Unix fds
4cdf5f0 
The conversions were originally removed in
705ec14. This commit restores them, but
puts them into a separate opam package luv_unix. The conversions can be
accessed as, for example, Luv_unix.Os_fd.Fd.from_unix. The main package
Luv also provides "neater" paths Luv.Unix.Os_fd.Fd.from_unix through a
module alias.

Resolves #90.

In the future, luv_unix needs a constraint to require the next release
of Luv (probably 0.5.7). The module also needs to be linked from the API
docs.
aantron added a commit that referenced this issue Jan 14, 2021
@aantron
Restore conversions between libuv and Unix fds
9e2bd87 
The conversions were originally removed in
705ec14. This commit restores them, but
puts them into a separate opam package luv_unix. The conversions can be
accessed as, for example, Luv_unix.Os_fd.Fd.from_unix. The main package
Luv also provides "neater" paths Luv.Unix.Os_fd.Fd.from_unix through a
module alias.

Resolves #90.

In the future, luv_unix needs a constraint to require the next release
of Luv (probably 0.5.7). The module also needs to be linked from the API
docs.
@aantron aantron closed this as completed in decdaad May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aantron