Bail out fast when no demangling is requested (google#915)

* Bail out fast when no demangling is requested Avoid trying to demangle functions one by one; besides, `demangleSingleFunction` doesn't quite behave correctly when **no** demangling is requested. * s/bail/Bail --------- Co-authored-by: Alexey Alexandrov <[email protected]>
aalexand · Dec 6, 2024 · 61a79c6 · 61a79c6
1 parent 484a855
commit 61a79c6
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/internal/symbolizer/symbolizer.go b/internal/symbolizer/symbolizer.go
@@ -257,6 +257,10 @@ func Demangle(prof *profile.Profile, force bool, demanglerMode string) {
 	}
 
 	options := demanglerModeToOptions(demanglerMode)
+	// Bail out fast to avoid any parsing, if we really don't want any demangling.
+	if len(options) == 0 {
+		return
+	}
 	for _, fn := range prof.Function {
 		demangleSingleFunction(fn, options)
 	}