Add project creation API endpoint #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration tests are missing pending a suitable mocking strategy.
AdrianoKF
added
enhancement
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
==========================================
+ Coverage 57.34% 58.91% +1.57%
==========================================
Files 66 69 +3
Lines 3247 3420 +173
==========================================
+ Hits 1862 2015 +153
- Misses 1385 1405 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nicholasjng
reviewed
Oct 31, 2024
Comment on lines
66
to
67
| # Create local queue if it doesn't exist | ||
| local_queue = kueue.get_local_queue(project.local_queue, project.namespace) |
There was a problem hiding this comment.
Could also be an ensure pattern like the namespace bit above, or am I missing something?
i.e. local_queue = kueue.ensure_local_queue(...)
|
|
||
| class LocalQueueResourceUsage(BaseModel): | ||
| name: str | ||
| total: Any |
There was a problem hiding this comment.
Is that a JSON struct, or something else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the data model for the Project entity, along with a creation API endpoint
POST /projects:An Alembic migration that includes the project table has been created.
Behavior of the
POST /projectscreation endpoint:Note
Testing: the
db()fixture intests/integration/conftest.pyautomatically creates a temporary SQLite database and applies all database migrations.If you want to manually inspect the database contents after a test session, you can put a
breakpoint()after theyieldstatement and get the database path fromf.name.Open Questions
TODOcomment)