Add missing expectation re: clients.length, don't do unnecessary check

for pubsub connection
aahoughton · Mar 5, 2015 · 050425b · 050425b
1 parent 0e77c0c
commit 050425b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/index.js b/index.js
@@ -67,8 +67,8 @@ Sentinel.prototype.createClientInternal = function(masterName, opts) {
     var self = this;
 
     client.on('end', function() {
-        // if we're purposefully ending and we're not our pubsub client, forget us
-        if (this.closing && self.pubsub.indexOf(this) === -1) {
+        // if we're purposefully ending, forget us
+        if (this.closing) {
             var index = self.clients.indexOf(this);
             if (index !== -1) {
                 self.clients.splice(index, 1);

diff --git a/test/test.js b/test/test.js
@@ -210,6 +210,7 @@ describe('Redis Sentinel tests', function() {
                     redisClient2.end();
 
                     instance.reconnectAllClients();
+                    expect(instance.clients.length).to.equal(2);
 
                     expect(redisClient2.info()).to.not.be.ok;