Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
import: fix incomplete successful imports during node failure
If a context cancellation occurs during import that aborts the import-files-to-kv goroutine the ingestKvs goroutine could short circuit and randomly not fail (ie not return an error) if the select chose the progress arm over the done checking arm of its select. This would record the progress so that on subsequent import retries we'd think we were done with those rows but we'd never actually have ingested them. Fix this by only recording the progress if both goroutines sucessfully complete without error. Fixes: cockroachdb#108547 Epic: None Release note (bug fix): Fixed a bug that could cause some rows to be silently skipped during IMPORT when a node failed.
- Loading branch information