dbconsole: remove non useful charts on the overload page

In investigations, we have found that the following charts are not useful and frequently cause confusion: - Admission work rate - Admission Delay rate - Requests Waiting For Flow Tokens Informs cockroachdb#121572 Release note (ui change): This patch removes "Admission Delay Rate", "Admission Work Rate", and "Requests Waiting For Flow Tokens". These charts often cause confusion and are not useful for general overload investigations.
aadityasondhi · May 2, 2024 · 456b275 · 456b275
1 parent 592e709
commit 456b275
Showing 1 changed file with 0 additions and 131 deletions.
diff --git a/pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/overload.tsx b/pkg/ui/workspaces/db-console/src/views/cluster/containers/nodeGraphs/dashboards/overload.tsx
@@ -238,38 +238,6 @@ export default function (props: GraphDashboardProps) {
       </Axis>
     </LineGraph>,
 
-    <LineGraph
-      title="Requests Waiting For Flow Tokens"
-      sources={nodeSources}
-      tenantSource={tenantSource}
-      showMetricsInTooltip={true}
-    >
-      <Axis label="Count">
-        {nodeIDs.map(nid => (
-          <>
-            <Metric
-              key={nid}
-              name="cr.node.kvadmission.flow_controller.regular_requests_waiting"
-              title={
-                "Regular requests waiting " +
-                nodeDisplayName(nodeDisplayNameByID, nid)
-              }
-              sources={[nid]}
-            />
-            <Metric
-              key={nid}
-              name="cr.node.kvadmission.flow_controller.elastic_requests_waiting"
-              title={
-                "Elastic requests waiting " +
-                nodeDisplayName(nodeDisplayNameByID, nid)
-              }
-              sources={[nid]}
-            />
-          </>
-        ))}
-      </Axis>
-    </LineGraph>,
-
     <LineGraph
       title="Blocked Replication Streams"
       sources={nodeSources}
@@ -302,105 +270,6 @@ export default function (props: GraphDashboardProps) {
       </Axis>
     </LineGraph>,
 
-    <LineGraph
-      title="Admission Work Rate"
-      sources={nodeSources}
-      tenantSource={tenantSource}
-      showMetricsInTooltip={true}
-    >
-      <Axis label="work rate">
-        {nodeIDs.map(nid => (
-          <>
-            <Metric
-              key={nid}
-              name="cr.node.admission.admitted.kv"
-              title={
-                "KV request rate " + nodeDisplayName(nodeDisplayNameByID, nid)
-              }
-              sources={[nid]}
-              nonNegativeRate
-            />
-            <Metric
-              key={nid}
-              name="cr.node.admission.admitted.kv-stores"
-              title={
-                "KV write request rate " +
-                nodeDisplayName(nodeDisplayNameByID, nid)
-              }
-              sources={[nid]}
-              nonNegativeRate
-            />
-            <Metric
-              key={nid}
-              name="cr.node.admission.admitted.sql-kv-response"
-              title={
-                "SQL-KV response rate " +
-                nodeDisplayName(nodeDisplayNameByID, nid)
-              }
-              sources={[nid]}
-              nonNegativeRate
-            />
-            <Metric
-              key={nid}
-              name="cr.node.admission.admitted.sql-sql-response"
-              title={
-                "SQL-SQL response rate " +
-                nodeDisplayName(nodeDisplayNameByID, nid)
-              }
-              sources={[nid]}
-              nonNegativeRate
-            />
-          </>
-        ))}
-      </Axis>
-    </LineGraph>,
-
-    <LineGraph
-      title="Admission Delay Rate"
-      sources={nodeSources}
-      tenantSource={tenantSource}
-      showMetricsInTooltip={true}
-    >
-      <Axis label="delay rate (micros/sec)">
-        {nodeIDs.map(nid => (
-          <>
-            <Metric
-              key={nid}
-              name="cr.node.admission.wait_durations.kv-sum"
-              title={"KV " + nodeDisplayName(nodeDisplayNameByID, nid)}
-              sources={[nid]}
-              nonNegativeRate
-            />
-            <Metric
-              key={nid}
-              name="cr.node.admission.wait_durations.kv-stores-sum"
-              title={"KV write " + nodeDisplayName(nodeDisplayNameByID, nid)}
-              sources={[nid]}
-              nonNegativeRate
-            />
-            <Metric
-              key={nid}
-              name="cr.node.admission.wait_durations.sql-kv-response-sum"
-              title={
-                "SQL-KV response " + nodeDisplayName(nodeDisplayNameByID, nid)
-              }
-              sources={[nid]}
-              nonNegativeRate
-            />
-            <Metric
-              key={nid}
-              name="cr.node.admission.wait_durations.sql-sql-response-sum"
-              title={
-                "SQL-SQL response " + nodeDisplayName(nodeDisplayNameByID, nid)
-              }
-              sources={[nid]}
-              nonNegativeRate
-            />
-          </>
-        ))}
-      </Axis>
-    </LineGraph>,
-
     <LineGraph
       title="Admission Delay: 75th percentile"
       sources={nodeSources}