Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed config/saml2_settings.php config/saml2.php #151

Open
wants to merge 1 commit into
base: remove_mcrypt
Choose a base branch
from
Open

Renamed config/saml2_settings.php config/saml2.php #151

wants to merge 1 commit into from

Conversation

tjallingt
Copy link

config/saml2_settings.php and config('saml2_settings') feel kinda redundant, renamed everything to just be saml2 instead.

I send it to this branch because this feels kind of like the "next version" branch and this is a breaking change (although easy to resolve)

@rlcurrall
Copy link
Contributor

rlcurrall commented Oct 9, 2019

This is a kind of old pull request, but would this not break the IdP configurations?

Just poking around in tinker, if I rename the file saml2.php then try to access a configuration for a given IdP which would be in the file /config/saml2/test_idp_settings.php using config('saml2.test_idp_settings'); I get null as it is unable to access those files.

On a second pass it looks like it depends on the version of Laravel you are using. I've only tested it on two versions so far. I know that it doesn't work on 5.4 but it does work on 6.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants