fix: empty container IP address while it's attached to another container #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a container's networking stack is attached to another container, the IP address of the container is empty and resulting DockerManager keep triggering retry and restart. Note: The restart loop triggered even the `com.dnsdock.ignore` label has added.
0w0mewo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a container is attached to another container's networking stack, the IP address of the container is empty and resulting
DockerManagerkeep triggering retry and restart.This PR fills the empty IP address with the attached container's IP address.
Note: The restart loop triggered even the
com.dnsdock.ignorelabel has added becauseoverrideFromLabels()andoverrideFromEnv()will returnniland causeDockerManger.getService()returns a non-nil error whenservice == niland trigger the restart loop. Therefore, I explicitly add a field inServicestruct to mark the service as 'ignored' instead of returningnil,