Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK-412 Bug: drawer button does not stick bottom #325

Merged
merged 3 commits into from
Mar 26, 2021

Conversation

Ehevi
Copy link
Collaborator

@Ehevi Ehevi commented Mar 26, 2021

No description provided.

@cypress
Copy link

cypress bot commented Mar 26, 2021



Test summary

220 3 0 0Flakiness 0


Run details

Project NurseScheduling
Status Failed
Commit c1b9ab5
Started Mar 26, 2021 12:41 PM
Ended Mar 26, 2021 12:44 PM
Duration 03:10 💡
OS Linux Ubuntu - 20.04
Browser Custom chrome 88

View run in Cypress Dashboard ➡️


Failures

cypress/integration/e2e/table/undo-redo.spec.ts Failed
1 Undo/Redo test > Should change worker (worker group: 1) shift and use undo and redo buttons to set proper cell state
2 Undo/Redo test > Should change worker (worker group: 0shift and use undo and redo shortcuts to set proper cell state
3 Undo/Redo test > Should change worker (worker group: 1shift and use undo and redo shortcuts to set proper cell state

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@prenc prenc changed the title TASK-412 drawer bottom button placement (bug) TASK-412 Bug: drawer button does not stick bottom Mar 26, 2021
Copy link
Member

@Qwebeck Qwebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dalej jest ten problem

image

@Qwebeck
Copy link
Member

Qwebeck commented Mar 26, 2021

Problem jest kiedy zwiększamy skalę
image

@Ehevi
Copy link
Collaborator Author

Ehevi commented Mar 26, 2021

Problem jest kiedy zwiększamy skalę
image

Wiem, już sprawdziłam i przeliczyłam odległość top na bottom. I jak teraz?

@Qwebeck
Copy link
Member

Qwebeck commented Mar 26, 2021

image

Copy link
Member

@Qwebeck Qwebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Już jest dobrze.

Później poprawimy tę drugą uwagę o której pisałem, bo teraz to raczej nie będzie im przeszkadzać(wątpię żeby aż na tyle przybliżali)

@Qwebeck Qwebeck merged commit d603d51 into develop Mar 26, 2021
@Qwebeck Qwebeck deleted the TASK-412-drawer-button-bug branch March 26, 2021 12:50
prenc added a commit that referenced this pull request Mar 26, 2021
* TASK-321 Introduce workers' teams (#293)

* TASK-362 Use excel spreadsheet to import and export shifts (#291)

* TASK-408 Add information about worker team to management table (#298)

* TASK-408 Adds information about worker group to managament table and allows to change worker group

* Fixes z-index

* Adds groups sotring

* TASK-411 Export with worker groups (#299)

* Change error folding section display (#308)

* Fix corrupted schedule test case (#310)

* TASK-330 Track app version and store it presistently  (#273)

* TASK-327 Use worker shifts from state (#264)

* TASK-394 New free shifts (#304)

* TASK-410 Not working switch between actual and base versions & TASK-420 always same default group in worker drawer (#312)

* TASK-423 sticky month header (#314)

* TASK-416 Sort workers in groups  && TASK-406 Display worker markers on schedule (#309)

* TASK-409 Show import bug messages for all import buttons (#307)

* TASK-423 Remove background of schedule's header  (#315)

* First push <3

* Done?.

* Ready for review.

* Ready for review.

* Unreal changes.

* Removed comments, reverted to develop styling.

* Epic changes.

* HEIGHT FIXED.

Co-authored-by: Tomasz Pęcak <[email protected]>

* TASK-422 Fixes export of worker calendar (#313)

* TASK-425 disables edit buttons (#318)

* TASK-386 Enhance comprehensibility of error messages (#302)

* Add mapping to uid for employee info contractType and workerGroup keys (#311)

* Add bunch of prerelease fixes (#321)

* TASK-419 Style non-working shifts consistently (#316)

* TASK-412 Bug: drawer button does not stick bottom  (#325)

* TASK-386 Enhance comprehensibility of error messages (follow-up) (#326)

* Fix shift types that was not defined (#327)

* Fix cell input (#328)

* Fix onBlur when no value provided (#329)

* Fix logs from shifts (#331)

* Fix work norm calculation for not working shifts (#332)

Co-authored-by: Bohdan <[email protected]>
Co-authored-by: Paulina <[email protected]>
Co-authored-by: Tomasz Pęcak <[email protected]>
Co-authored-by: Maciej Bielech <[email protected]>
Co-authored-by: Jan Ślażyński <[email protected]>
Co-authored-by: Ehevi <[email protected]>
Co-authored-by: Szymon Fugas <[email protected]>
github-actions bot pushed a commit that referenced this pull request Mar 26, 2021
## [1.0.2](v1.0.1...v1.0.2) (2021-03-26)

### Performance Improvements

* **App:** Release v2.0.0 ([#323](#323)) ([cdc701d](cdc701d)), closes [#293](#293) [#291](#291) [#298](#298) [#299](#299) [#308](#308) [#310](#310) [#273](#273) [#264](#264) [#304](#304) [#312](#312) [#314](#314) [#309](#309) [#307](#307) [#315](#315) [#313](#313) [#318](#318) [#302](#302) [#311](#311) [#321](#321) [#316](#316) [#325](#325) [#326](#326) [#327](#327) [#328](#328) [#329](#329) [#331](#331) [#332](#332)
github-actions bot pushed a commit that referenced this pull request Mar 26, 2021
## [1.0.2](v1.0.1...v1.0.2) (2021-03-26)

### Performance Improvements

* **App:** Release v2.0.0 ([#323](#323)) ([cdc701d](cdc701d)), closes [#293](#293) [#291](#291) [#298](#298) [#299](#299) [#308](#308) [#310](#310) [#273](#273) [#264](#264) [#304](#304) [#312](#312) [#314](#314) [#309](#309) [#307](#307) [#315](#315) [#313](#313) [#318](#318) [#302](#302) [#311](#311) [#321](#321) [#316](#316) [#325](#325) [#326](#326) [#327](#327) [#328](#328) [#329](#329) [#331](#331) [#332](#332)
prenc added a commit that referenced this pull request Mar 26, 2021
* TASK-321 Introduce workers' teams (#293)

* TASK-362 Use excel spreadsheet to import and export shifts (#291)

* TASK-408 Add information about worker team to management table (#298)

* TASK-408 Adds information about worker group to managament table and allows to change worker group

* Fixes z-index

* Adds groups sotring

* TASK-411 Export with worker groups (#299)

* Change error folding section display (#308)

* Fix corrupted schedule test case (#310)

* TASK-330 Track app version and store it presistently  (#273)

* TASK-327 Use worker shifts from state (#264)

* TASK-394 New free shifts (#304)

* TASK-410 Not working switch between actual and base versions & TASK-420 always same default group in worker drawer (#312)

* TASK-423 sticky month header (#314)

* TASK-416 Sort workers in groups  && TASK-406 Display worker markers on schedule (#309)

* TASK-409 Show import bug messages for all import buttons (#307)

* TASK-423 Remove background of schedule's header  (#315)

* First push <3

* Done?.

* Ready for review.

* Ready for review.

* Unreal changes.

* Removed comments, reverted to develop styling.

* Epic changes.

* HEIGHT FIXED.

Co-authored-by: Tomasz Pęcak <[email protected]>

* TASK-422 Fixes export of worker calendar (#313)

* TASK-425 disables edit buttons (#318)

* TASK-386 Enhance comprehensibility of error messages (#302)

* Add mapping to uid for employee info contractType and workerGroup keys (#311)

* Add bunch of prerelease fixes (#321)

* TASK-419 Style non-working shifts consistently (#316)

* TASK-412 Bug: drawer button does not stick bottom  (#325)

* TASK-386 Enhance comprehensibility of error messages (follow-up) (#326)

* Fix shift types that was not defined (#327)

* Fix cell input (#328)

* Fix onBlur when no value provided (#329)

* Fix logs from shifts (#331)

* Fix work norm calculation for not working shifts (#332)

Co-authored-by: Bohdan <[email protected]>
Co-authored-by: Paulina <[email protected]>
Co-authored-by: Tomasz Pęcak <[email protected]>
Co-authored-by: Maciej Bielech <[email protected]>
Co-authored-by: Jan Ślażyński <[email protected]>
Co-authored-by: Ehevi <[email protected]>
Co-authored-by: Szymon Fugas <[email protected]>
github-actions bot pushed a commit that referenced this pull request Mar 26, 2021
## [1.0.2](v1.0.1...v1.0.2) (2021-03-26)

### Performance Improvements

* **App:** Release v2.0.0 ([#323](#323)) ([cdc701d](cdc701d)), closes [#293](#293) [#291](#291) [#298](#298) [#299](#299) [#308](#308) [#310](#310) [#273](#273) [#264](#264) [#304](#304) [#312](#312) [#314](#314) [#309](#309) [#307](#307) [#315](#315) [#313](#313) [#318](#318) [#302](#302) [#311](#311) [#321](#321) [#316](#316) [#325](#325) [#326](#326) [#327](#327) [#328](#328) [#329](#329) [#331](#331) [#332](#332)
* **App:** Release v2.0.0 ([#333](#333)) ([230ae80](230ae80)), closes [#293](#293) [#291](#291) [#298](#298) [#299](#299) [#308](#308) [#310](#310) [#273](#273) [#264](#264) [#304](#304) [#312](#312) [#314](#314) [#309](#309) [#307](#307) [#315](#315) [#313](#313) [#318](#318) [#302](#302) [#311](#311) [#321](#321) [#316](#316) [#325](#325) [#326](#326) [#327](#327) [#328](#328) [#329](#329) [#331](#331) [#332](#332)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants