Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK-387 Sort shifts in dropdown #282

Merged
merged 10 commits into from
Mar 18, 2021

Conversation

net-runner
Copy link
Contributor

Od teraz elementy w autocomplete dropdownie są sortowane w zależności od godzin pracy oraz wyświetlają się w jednej linii.

@net-runner net-runner requested a review from prenc March 16, 2021 19:43
@cypress
Copy link

cypress bot commented Mar 16, 2021



Test summary

232 0 0 0Flakiness 0


Run details

Project NurseScheduling
Status Passed
Commit 067aee3
Started Mar 18, 2021 6:38 PM
Ended Mar 18, 2021 6:42 PM
Duration 03:46 💡
OS Linux Ubuntu - 20.04
Browser Custom chrome 88

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@prenc prenc changed the title Finished. All tests passing. TASK-387 Sort shifts in dropdown Mar 16, 2021
prenc
prenc previously approved these changes Mar 16, 2021
Copy link
Contributor

@prenc prenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usuń jeszcze kursywę jak się najeżdża na odpowiednie zmiany, sam bold wystarczy.

@prenc prenc requested a review from Qwebeck March 16, 2021 20:09
Copy link
Member

@Qwebeck Qwebeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super praca!
Fajnie, że tak szybko wdrażasz się w projekt i dokładasz ważne rzeczy ;D

Daję na razie request changes, ale to głównie z uwagi na komentarz oraz na "wolne" które pojawia się w kodzie.

@net-runner net-runner requested a review from Qwebeck March 17, 2021 20:15
@net-runner net-runner requested a review from Qwebeck March 17, 2021 23:43
@Qwebeck Qwebeck merged commit 36dd18e into develop Mar 18, 2021
@Qwebeck Qwebeck deleted the TASK-387-sort-and-rendering-fix-for-dropdown-shifts branch March 18, 2021 18:42
Qwebeck pushed a commit that referenced this pull request Mar 20, 2021
prenc pushed a commit that referenced this pull request Mar 22, 2021
prenc added a commit that referenced this pull request Mar 22, 2021
* TASK-338 Enable database clear when error appears  (#249)

* Save file with proper name, save all db docs when error button clicked

* Modify database export and export all schedules in zip

* Set proper zip name

* Fix and extend filehelper test

* Move handle dummp to file helper, remove comments

* Fix file helper test

* Add custom types instead of inline dicts

* Save correct timestamp

* TASK-343 Handle rendering crushes at schedule level (#257)

* TASK-323 Add min char number indication in report issue modal (#262)

* Task 348 Enable undo on corrupted schedule page (#265)

* TASK-345 Improve descriptions of found schedule's issues (#263)

* TASK-371 Bug: wrong errors when 31-day month (#271)

* export workers (#267)

Co-authored-by: Tomasz Pęcak <[email protected]>
Co-authored-by: Paweł Renc <[email protected]>

* TASK-324 Reduce hour number based on previously scheduled shifts for L4 (#259)

* TASK-319 Export number of daytime employees information (#260)

* Task 291 Copy month to full schedule (including next month) (#272)

* Fixes bad key setting (#275)

* TASK-322 Bug: fix missing colors in Excel export for employees having no shifts (#258)

* TASK-333 && TASK-335 Asking about unsaved changes when exiting edit mode && disabling undo/redo/save buttons (#270)

* TASK-370 Fix restoring state on corrupted schedule page (#276)

* TASK-362 Parse workers info from excel (#269)

* TASK-375 Bug: app crashes when copying from month ending on sunday (#280)

* TASK-314 Another iteration over excel layout of exported schedule (#278)

* bugfixes

* implements function to decide font color

* added links

* small fixes

Co-authored-by: Tomasz Pęcak <[email protected]>

* TASK-389 Close issue drawer when exiting edit mode (#285)

* Bug fixed. Cypress passing.

* Added isEditMode watcher for auto drawer closing.

* TASK-376 Error modal doesn't appear on app error (#286)

* Handle error on higher tree level

* Add error message for testing purposes

* TASK-350 Keep shifts scheduled in next month's days  (#283)

* Add corrupted info to schedule state

* Stash branch changes

* Restore prev storage initialization

* Do not replace free shifts in first week

* TASK-387 Sort shifts in dropdown (#282)

* TASK-361 autocomplete component rendering fix (#284)

* TASK-304 Another iteration over drawer for managing workers (#279)

* TASK-388 Now edit state is properly false after leaving edit mode. BUGFIXED (#290)

* TASK-256 Add exporting employees' small calendar to pdf (#277)

* TASK-379 Add worker to single month (#289)

* TASK-339 & TASK-382 fix all console errors & increase folding performance (#288)

* TASK-391 fixed calculation of worker norm when added during the month with parttime contract. (#295)

* TASK-390 Stick footer to bottom of page, not viewport (#294)

* Change footer to be the end of the content, rather than sticked to the bottom of the screen. Remove electron block

* Footer always on the bottom of the page

* Repair jira like drawer after footer changes. Repair zarzadzanie tab

Co-authored-by: Tomasz Pęcak <[email protected]>
Co-authored-by: Ehevi <[email protected]>
Co-authored-by: Paulina <[email protected]>
Co-authored-by: Bohdan <[email protected]>
Co-authored-by: Vyacheslav Trushkov <[email protected]>
Co-authored-by: kopcion <[email protected]>
Co-authored-by: Jan Ślażyński <[email protected]>
Co-authored-by: Maciej Bielech <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants