Fix: Declare getopt function on older GNU libc
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a4lg
force-pushed
the
include-getopt-fix-on-old-glibc
branch
3 times, most recently
from
810a22f to
5a0c7bd
Compare
On GNU libc <= 2.25, <unistd.h> includes <getopt.h> with __need_getopt macro
defined. That <getopt.h> is intended to be a part of GNU libc but
<unistd.h> actually includes include/getopt.h in this project.
If HAVE_DECL_GETOPT is defined to 1 and include/getopt.h is included from
GNU libc's <unistd.h>, declaration of getopt is suppressed, causing errors
on getopt callers. This issue is possibly hidden so long because there are
not so many true getopt callers in Binutils, GDB and GCC. Still, this issue
needs to be fixed for following components:
- Binutils: gprofng
(not currently affected due to the configuration script but will be)
- GDB (sim): M32C simulator
- GDB (sim): RL78 simulator
To avoid not defining proper getopt declaration, we have to check
__need_getopt macro to detect this include path. With this commit, even if
HAVE_DECL_GETOPT is 1, getopt is declared if:
- The standard C library is GNU libc and
- __need_getopt macro is defined (<unistd.h> includes <getopt.h> to
declare getopt function).
include/ChangeLog:
* getopt.h: Detect special include path on GNU libc 2.25 or older
to prevent not declaring getopt function when necessary.
a4lg
force-pushed
the
include-getopt-fix-on-old-glibc
branch
from
5a0c7bd to
7aeadcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wiki Page (details): https://github.com/a4lg/binutils-gdb/wiki/include_getopt_fix_on_old_glibc