Fix: Support Extension version 0.0 #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the ISA string with "xextname0p0" is handled as the 'Xextname' without version number information (not version 0.0 as specified in the string). This commit makes able to handle version 0.0 and enable handling placeholder extensions (with *actual* version number) easily (without being handled as an unknown version). This behavior is consistent with other locations that use the "find_any_version" variable. bfd/ChangeLog: * elfxx-riscv.c (riscv_parsing_subset_version): Check whether we have actually found a version number.
a4lg
force-pushed
the
riscv-ext-support-version-0p0
branch
from
ed8886b to
1f10468
Compare
|
Closing as "not an issue". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wiki Page (details): https://github.com/a4lg/binutils-gdb/wiki/riscv_ext_support_version_0p0