Skip to content

Commit

Permalink
[gdb/testsuite] Fix py-autoloaded-pretty-printers-in-newobjfile-event…
Browse files Browse the repository at this point in the history
….exp for remote target

With test-case gdb.python/py-autoloaded-pretty-printers-in-newobjfile-event.exp
and target board remote-gdbserver-on-localhost, I run into:
...
FAIL: $exp: runto: run to main
...

I can easily fix this using "gdb_load_shlib $binfile_lib", but then run into:
...
(gdb) print all_good^M
$1 = false^M
(gdb) FAIL: $exp: print all_good
info pretty-printer^M
...

Sysroot is set to "target:", so gdb downloads the shared library from the target
(Using $so as shorthand for
libpy-autoloaded-pretty-printers-in-newobjfile-event.so):
...
Reading /home/remote-target/$so from remote target...^M
...
and internally refers to it as "target:/home/remote-target/$so".

In load_auto_scripts_for_objfile, gdb gives up trying to auto-load scripts
for $so once it checks for is_target_filename.

Fix this by declaring auto-load unsupported if sysroot starts with "target:".

Tested on x86_64-linux.
  • Loading branch information
vries committed Mar 10, 2023
1 parent 69b956f commit ddc003b
Showing 1 changed file with 17 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,28 @@ set remote_python_event_handler_file\
gdb_test_no_output "source ${remote_python_event_handler_file}" "load python file"

gdb_load ${binfile}
gdb_load_shlib $binfile_lib

if { ![runto_main] } {
return
}

if { [is_remote target ] } {
set target_sysroot 0
gdb_test_multiple "show sysroot" "" {
-re -wrap "\r\nThe current system root is \"target:.*\"\\." {
set target_sysroot 1
}
-re -wrap "" {
}
}

if { $target_sysroot } {
unsupported "sysroot start with target: -- auto-load not supported"
return
}
}

# Check that the new_objfile handler saw the pretty-printer.
gdb_test "print all_good" " = true"

Expand Down

0 comments on commit ddc003b

Please sign in to comment.