Fix crash in "document" command

PR cli/29800 points out that "document" will now crash when the argument is an undefined command. This is a regression due to the "document user-defined aliases" patch. Approved-By: Joel Brobecker <[email protected]> Reviewed-By: Philippe Waroquiers <[email protected]> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29800
a4lg · Nov 28, 2022 · b70e927 · b70e927
1 parent 76cd77d
commit b70e927
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/gdb/cli/cli-script.c b/gdb/cli/cli-script.c
@@ -1515,6 +1515,8 @@ do_document_command (const char *comname, int from_tty,
   validate_comname (&comname);
 
   lookup_cmd_composition (comfull, &alias, &prefix_cmd, &c);
+  if (c == nullptr)
+    error (_("Undefined command: \"%s\"."), comfull);
 
   if (c->theclass != class_user
       && (alias == nullptr || alias->theclass != class_alias))

diff --git a/gdb/testsuite/gdb.base/document.exp b/gdb/testsuite/gdb.base/document.exp
@@ -28,3 +28,7 @@ gdb_test_multiple "define do-document" "" {
 }
 gdb_test_no_output "do-document" "invoke do-document"
 gdb_test "help do-document" "usage: do-document" "invoke help do-document"
+
+# Test that document of a non-existing command prints an error.  There
+# was a regression at one point causing this to crash.
+gdb_test "document nosuchcommand" "Undefined command: \"nosuchcommand\"\\."