Fix issues with new js interop #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rexios80
changed the title
|
There must still be an issue with the function getters but I'm not sure what. This exception seems to be internal to the Google Maps code. Do you have any ideas? ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following JSNoSuchMethodError was thrown running a test:
TypeError: Cannot read properties of undefined (reading 'x')
When the exception was thrown, this was the stack:
https://maps.googleapis.com/maps/api/js?key=AIzaSyAa9cRBkhuxGq3Xw3HPz8SPwaVOhRmm7kk&libraries=geometry 363:449 fromLatLngToPoint
packages/google_maps/src/generated/image_overlay/projection.dart 26:18 <fn>
packages/google_maps_flutter_web/src/third_party/to_screen_location/to_screen_location.dart 44:42 toScreenLocation
packages/google_maps_flutter_web/src/google_maps_controller.dart 406:9 getScreenCoordinate
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54 runBody
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 127:5 _async
packages/google_maps_flutter_web/src/google_maps_controller.dart 401:47 getScreenCoordinate
packages/google_maps_flutter_web/src/google_maps_flutter_web.dart 163:22 getScreenCoordinate
packages/google_maps_flutter/src/controller.dart 216:10 getScreenCoordinate
projection_test.dart 147:29 <fn>
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50 <fn>
dart-sdk/lib/async/zone.dart 1407:47 _rootRunUnary
dart-sdk/lib/async/zone.dart 1308:19 runUnary
dart-sdk/lib/async/future_impl.dart 163:18 handleValue
dart-sdk/lib/async/future_impl.dart 861:44 handleValueCallback
dart-sdk/lib/async/future_impl.dart 890:13 _propagateToListeners
dart-sdk/lib/async/future_impl.dart 666:5 [_completeWithValue]
dart-sdk/lib/async/future_impl.dart 736:7 <fn>
dart-sdk/lib/async/zone.dart 1399:13 _rootRun
dart-sdk/lib/async/zone.dart 1301:19 run
dart-sdk/lib/async/zone.dart 1209:7 runGuarded
dart-sdk/lib/async/zone.dart 1249:23 callback
dart-sdk/lib/async/schedule_microtask.dart 40:11 _microtaskLoop
dart-sdk/lib/async/schedule_microtask.dart 49:5 _startMicrotaskLoop
dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 181:7 <fn>
The test description was:
target of map is in center of widget
════════════════════════════════════════════════════════════════════════════════════════════════════ |
|
Thanks for your contribution. In all examples I never saw any explicit call of the function getter you added. Those functions are usually intended to be implemented for custom usage. Regarding the issue you faced I will try another pattern and see if it works. |
|
I refactored how getters of function are implemented in 5972ce5. I made a quick test that looks good. Could you try it on your Flutter PR? If it's ok I'll publish a new dev version. |
|
Unfortunately I get the same issue. I would say it's an issue with the test but it definitely works with the old |
|
I created #133 to track this |
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 31, 2024
Migrates `google_maps_flutter_web` to `google_maps: ^8.0.0` Blocked on the following: - a14n/dart-google-maps#132 - flutter/flutter#151426 - flutter/flutter#145149 - a14n/dart-google-maps#133 - flutter/flutter#151561 Fixes flutter/flutter#148624
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.