Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update html and yml to support pill/badge design system #567

Closed
wants to merge 2 commits into from

Conversation

gallexi
Copy link

@gallexi gallexi commented Dec 21, 2017

Starting some work on the pill/badge design system, per discussion in #531

@gallexi
Copy link
Author

gallexi commented Dec 21, 2017

@svinkle, @jenstrickland, these are my very first steps: just adding the code: field to each pattern, and starting to fill in a few. For the ones that aren't associated with a framework, do we want to do HTML, CSS, Javascript, depending on whether they actually use all three? Or maybe make a third thing, that's just like no framework, but nicer-sounding? 😁

@gallexi gallexi changed the title Add 'code' field to patterns.yml, fill in some Update html and yml to support pill/badge design system Dec 21, 2017
@ericwbailey
Copy link
Member

Looking really good so far, thank you!

"Vanilla" seems to be the go to term for frameworkless JavaScript, but it might be better to just stick with the underlying tech (HTML, CSS, JavaScript, etc.)? My thinking is if you don't know that Vanilla is an industry term, it could be confusion to beginners?

@scottaohara
Copy link
Member

scottaohara commented Dec 21, 2017

to @ericwbailey's point:
Anecdotally speaking, I've run into various junior developers who were utterly confused when I mentioned "vanilla javascript". wondering if i was talking about a new framework.

just "JavaScript" or "ES#" seemed to be perfectly understandable though.

That said, i personally like calling it "vanilla" so, as long as we just have something to indicate that vanilla = plain old no dependency javascript, I think we'd be ok

@svinkle
Copy link
Member

svinkle commented Dec 21, 2017

To me, "vanilla" = "JavaScript". Anything not vanilla would be called by its name; jquery, angular, etc.

That said, I also think "vanilla" = ES6. I know some folks are still getting ramped up on ES6 features but pretty well all (modern) browsers have support so I don't think it's worth differentiating.

@galantlex What you've got here is great! It's what I was thinking as well. 👍

@svinkle
Copy link
Member

svinkle commented Dec 21, 2017

We probably shouldn't merge until #568 is in.

@gallexi
Copy link
Author

gallexi commented Dec 21, 2017

As a somewhat junior developer, yeah, I had no idea VanillaJS wasn't some other new framework 😁

I'll continue on with HTML, CSS, JS, etc, and I'll make sure to test integration with #568 before merging in 👍

@svinkle
Copy link
Member

svinkle commented Aug 5, 2018

Stale PR: Please reissue with latest from gh-pages when available.

@svinkle svinkle closed this Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants