-
-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update html and yml to support pill/badge design system #567
Conversation
@svinkle, @jenstrickland, these are my very first steps: just adding the |
Looking really good so far, thank you! "Vanilla" seems to be the go to term for frameworkless JavaScript, but it might be better to just stick with the underlying tech (HTML, CSS, JavaScript, etc.)? My thinking is if you don't know that Vanilla is an industry term, it could be confusion to beginners? |
to @ericwbailey's point: just "JavaScript" or "ES#" seemed to be perfectly understandable though. That said, i personally like calling it "vanilla" so, as long as we just have something to indicate that vanilla = plain old no dependency javascript, I think we'd be ok |
To me, "vanilla" = "JavaScript". Anything not vanilla would be called by its name; jquery, angular, etc. That said, I also think "vanilla" = ES6. I know some folks are still getting ramped up on ES6 features but pretty well all (modern) browsers have support so I don't think it's worth differentiating. @galantlex What you've got here is great! It's what I was thinking as well. 👍 |
We probably shouldn't merge until #568 is in. |
As a somewhat junior developer, yeah, I had no idea VanillaJS wasn't some other new framework 😁 I'll continue on with HTML, CSS, JS, etc, and I'll make sure to test integration with #568 before merging in 👍 |
Stale PR: Please reissue with latest from |
Starting some work on the pill/badge design system, per discussion in #531