Add support for direct URL fetching. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scie-pants project will leverage this in an install binding that needs to fetch Pants version information from PyPI and GitHub in certain circumstances. Along the way, improve CLI help and switch to anyhow for better error handling.
|
Another ~FYI review. This came out of getting |
|
@chrisjrn I've extended an invite to the repo so I can add you to reviews. This is mainly FYI for the upcoming scie-pants PRs which I'd definitely like your feedback and hawk-eye on. |
|
👍
…On Sun, 4 Dec 2022, 18:38 John Sirois, ***@***.***> wrote:
@chrisjrn <https://github.com/chrisjrn> I've extended an invite to the
repo so I can add you to reviews. This is mainly FYI for the upcoming
scie-pants PRs which I'd definitely like your feedback and hawk-eye on.
—
Reply to this email directly, view it on GitHub
<#21 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEX5XC77QQKA4U4LQ7HLW3WLVIS3ANCNFSM6AAAAAASTXRFCY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scie-pants project will leverage this in an install binding that
needs to fetch Pants version information from PyPI and GitHub in certain
circumstances.
Along the way, improve CLI help and switch to anyhow for better error
handling.