Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offer suggestions for lift manifest typos. #51

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Offer suggestions for lift manifest typos. #51

merged 3 commits into from
Sep 29, 2023

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented Sep 29, 2023

Also make the array indexing basis clear when array indexes are used.

@jsirois
Offer suggestions for lift manifest typos.
64024b1 
Also make the array indexing basis clear when array indexes are used.
huonw
huonw approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor optional notes from me.

tests/data/unrecognized-config-fields.toml Outdated Show resolved Hide resolved
science/config.py Outdated Show resolved Hide resolved
@jsirois jsirois merged commit 79bb1cb into a-scie:main Sep 29, 2023
6 checks passed
@jsirois jsirois deleted the config/did-you-mean branch September 29, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huonw huonw huonw approved these changes

@kaos kaos Awaiting requested review from kaos

@benjyw benjyw Awaiting requested review from benjyw

@sureshjoshi sureshjoshi Awaiting requested review from sureshjoshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsirois @huonw