Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix detection of previous PR annotation comments #2

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix detection of previous PR annotation comments #2

merged 1 commit into from
Jul 9, 2024

Commits on Apr 17, 2024

  1. Fix detection of previous PR annotation comments 

    MarkdownFormatterFactory uses System.lineSeparator() as the end-of-line
character for annotation comments.

GraphqlGithubClient.postSummaryComment(), however, uses hardcoded \r\n
as end-of-line character, so it isn't able to match legitimate comments
if SonarQube is not running on Windows.

This change updates GraphqlGithubClient to also use system end-of-line
char.
    @GreyTeardrop
    GreyTeardrop committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    c7f801f View commit details
    Browse the repository at this point in the history