Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): update URI handling for non-templ files for references #899

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

tris203
Copy link
Contributor

@tris203 tris203 commented Aug 28, 2024

Closes #893

This took far too long to find but seems to resolve the issue for me

@tris203 tris203 changed the title fix(server): update URI handling for non-templ files for references fix(lsp): update URI handling for non-templ files for references Aug 29, 2024
@tris203
Copy link
Contributor Author

tris203 commented Sep 5, 2024

I think this is ready for a review

@joerdav joerdav self-assigned this Sep 6, 2024
@joerdav
Copy link
Collaborator

joerdav commented Sep 6, 2024

Great thanks so much for the contribution! I will test this out, I also think that this could benefit from an additional test in https://github.com/a-h/templ/blob/main/cmd/templ/lspcmd/lsp_test.go if you have time? @a-h has built a nice test framework for unit testing the LSP.

If you don't have time let me know and I can pick that up.

@tris203
Copy link
Contributor Author

tris203 commented Sep 6, 2024

Great thanks so much for the contribution! I will test this out, I also think that this could benefit from an additional test in main/cmd/templ/lspcmd/lsp_test.go if you have time? @a-h has built a nice test framework for unit testing the LSP.

If you don't have time let me know and I can pick that up.

I have added a test @joerdav
I tried to integrate it in the same style as the others, let me know if there is anything you want changed

@joerdav
Copy link
Collaborator

joerdav commented Sep 6, 2024

I've just added one more for a reference within a templ file, but now I think this is good to go. Thanks for the contribution!

@joerdav joerdav merged commit dcc8987 into a-h:main Sep 6, 2024
4 checks passed
@tris203 tris203 deleted the uri_rewrite branch September 6, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: go to definition causes error in Neovim v0.10.x
2 participants