feat: support void element parsing, fixes #637 #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 🎉 |
joerdav
approved these changes
May 10, 2024
There was a problem hiding this comment.
This looks great to me, glad to see the diagnoser coming in handy again!
On thing I spotted, feel free to merge without as it is fine without, Is that rather than adding to the TestFormatter test you could add to the other formatter tests:
https://github.com/a-h/templ/tree/main/parser/v2/testdata
To be honest we could probably remove that test entirely, I find the txt files easier to add than the table tests.
|
I've migrated the tests to the txtar format. |
|
I hope you wrote a script to do that for you lol! |
|
I did! 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.