Fix overly greedy parsing in raw elements parser #702
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I have been using templ for a project where I am using non-standard HTML elements and I hit a parse error when I used a tag named
<scripts>
.In the existing code, if the raw element name is successfully parsed, it immediately attempts to parse the attributes, without checking for whitespace or a closing
>
.This means that something like
<scripts>
would be parsed as a<script>
tag with a boolean attribute ofs
(the last character of the tag name). This would then give a confusing error about mismatched tags as the closing</scripts>
tag was actually parsed correctly.This commit fixes this issue by delegating to the
elementNameParser
, which checks for white space or a closing>
, and then compares the name of the expected raw element.