Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support build tags by copying template header over #688

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

joerdav
Copy link
Collaborator

@joerdav joerdav commented Apr 17, 2024

Closes #625

Excuse the diff, my formatter got a bit trigger happy. I also moved some tests to the txtar format.

@a-h
Copy link
Owner

a-h commented Apr 17, 2024

Would you be able to stop that formatter from putting args on new lines? It looks like it's optimising for 80 chars. 😁

@a-h a-h changed the title feat: suppord build tags by copying template header over feat: support build tags by copying template header over Apr 17, 2024
@joerdav
Copy link
Collaborator Author

joerdav commented Apr 17, 2024

Sure, I always use gofumpt which is quite opinionated.

@joerdav
Copy link
Collaborator Author

joerdav commented Apr 17, 2024

Done!

@a-h a-h merged commit 6af8b3b into main Apr 19, 2024
7 checks passed
@a-h a-h deleted the support-build-tags branch April 19, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: go:build tags support?
2 participants