Css args #484
Merged
Css args #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-h
approved these changes
Feb 1, 2024
| @@ -28,7 +28,7 @@ var templateExpressionParser = parse.Func(func(pi *parse.Input) (r templateExpre | |||
| // templ (x []string) Test() { | |||
| // becomes: | |||
| // func (x []string) Test() templ.Component { | |||
| if r.Expression, err = parseGoFuncDecl(pi); err != nil { | |||
| if _, r.Expression, err = parseTemplFuncDecl(pi); err != nil { | |||
There was a problem hiding this comment.
I wonder if there's some debug value in the name of the templ, it could be passed down the context.
For example, the context could identify slow rendering components, or could print out a series of names: Page > Body > content > heading.
Not important, or that you need to do anything with this PR. Its just that your change sparked ideas. 😀
This was referenced Feb 2, 2024
|
Looks very nice! The example in the documentation showcases an integer parameter, does it also handle strings? Like for example background url('{ myVar }'). If so, what kind of escaping is used? |
|
It looks exactly the way I need it to look! 👍 @a-h when are you planning to release this? |
|
Plan to release tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88