Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: templ CLI panic with --proxy option #365

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Conversation

eussam
Copy link
Contributor

@eussam eussam commented Dec 26, 2023

fixes #358

@tantalic
Copy link
Contributor

Watching this one in hopes it resolves an issue we are having 🤞

@a-h a-h merged commit f0fb971 into a-h:main Dec 30, 2023
4 checks passed
@a-h
Copy link
Owner

a-h commented Dec 30, 2023

Thanks for that!

@eussam
Copy link
Contributor Author

eussam commented Dec 30, 2023

Thank you for giving me the opportunity to contribute @a-h 😃
Out of curiosity, could you tell me why you preferred not to have the inline function ?

@a-h
Copy link
Owner

a-h commented Dec 30, 2023

Only reason was so that the functionality can be followed by reading from top to bottom, rather than reading the function, and holding it in your mind until you see where and how it's used.

It was clear, but I thought it could be a tiny bit more direct without having the function variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot reload with templ proxy option panic
3 participants