Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kerbs #242

Merged
merged 6 commits into from
Mar 17, 2024
Merged

Add kerbs #242

merged 6 commits into from
Mar 17, 2024

Conversation

ginnyTheCat
Copy link
Contributor

Adds kerb positions generated by muv-osm to osm2streets as discussed in #232 and tracked by #240. This provides a higher level of detail as it allows one to easily distinguish cycleway=lane from cycleway=track on the map.

A cycleway moving from the roadway to the sidewalk

It behaved quite unexpected for me for highway=cycleway + sidewalk=* but this is what the wiki suggests. In case this is unwanted we can skip the kerb in this case in every country but the Netherlands.

@dabreegster
Copy link
Contributor

Thank you! I'll pick this up tomorrow. The rendering of the curb is a bit buggy; RenderLanePolygons.svelte probably needs a new case.

Relatedly, BufferType here can probably have an overhaul. I think https://wiki.openstreetmap.org/wiki/Proposal:Separation has caught on. I might have a go at some simple rendering for all of these cases. Downstream use cases might look at the quality of the separation of a cycleway from traffic.

Copy link
Contributor

@dabreegster dabreegster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some UI tweaks so it shows up, though really faintly. Thanks!

@dabreegster dabreegster merged commit 4aba5df into a-b-street:main Mar 17, 2024
@ginnyTheCat ginnyTheCat deleted the kerb branch March 17, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants