Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset the center line to untrimmed before calling intersection_polygo… #144

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

dabreegster
Copy link
Contributor

…n. Will revisit this at some point. #136, closes #143.

@dabreegster
Copy link
Contributor Author

The test diffs look fine.

Longer-term, we kind of have two approaches to decide between. Both should be compatible with the goal of always having a trimmed center_line and intersection.polygon filled out and not just calculating it last-minute in the transformation.

  1. Keep assuming the input to the intersection geometry routines is untrimmed. I think we'll always have enough state around to manage that. The only thing to maybe figure out is that we never lengthen a center line that was shorter in a previous pass. That was partly the motivation for storing trim_start and trim_end explicitly.

  2. Make the routines handle input that's already trimmed, and consider trimming further if something has changed. This feels harder to reason about to me, personally.

@dabreegster dabreegster merged commit 844740c into main Dec 7, 2022
@dabreegster dabreegster deleted the reset_geometry branch December 7, 2022 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GenerateIntersectionGeometry makes existing intersections larger
1 participant