This repository has been archived by the owner on Mar 9, 2023. It is now read-only.
More edit controls #260
Merged
More edit controls #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dabreegster
commented
Nov 7, 2022
| @@ -33,6 +35,13 @@ | |||
| width: 50px; | |||
| } | |||
|
|
|||
| .insert-lane { | |||
| position: absolute; | |||
| right: -15px; | |||
There was a problem hiding this comment.
Actually, I got the icons to be in a better place. Is this a reasonable way of achieving it?
There was a problem hiding this comment.
Perfect use of position: absolute! We want to anchor it to the bottom right of the card and that's idiomatic CSS to do so.
Benchmark for 7126333Click to view benchmark
|
Benchmark for d8065deClick to view benchmark
|
BudgieInWA
approved these changes
Nov 7, 2022
web_editor/js/cards.js
Outdated
| @@ -11,7 +11,8 @@ export function makeLaneCard(lane, idx, app) { | |||
| } | |||
| node.appendChild(wrapInCenterDiv(width(lane))); | |||
|
|
|||
| var finalRow = document.createElement("div"); | |||
| var editRow = document.createElement("div"); | |||
| editRow.align = "center"; | |||
There was a problem hiding this comment.
I'd prefer this done in CSS. text-align: center (for centering inline children of a block element) or margin: 0 auto (for centering a block element within its parent) will cover most cases.
Benchmark for 9cf476aClick to view benchmark
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#240
screencast.mp4
A next possible step is clicking the lane type icon to get a little modal popup and choose the type. So then inserting a lane and changing the type would become much more fluid