Skip to content
This repository has been archived by the owner on Mar 9, 2023. It is now read-only.

Gloo Workers v2 #214

Merged
merged 10 commits into from
Jun 19, 2022
Merged

Gloo Workers v2 #214

merged 10 commits into from
Jun 19, 2022

Conversation

droogmic
Copy link
Collaborator

This currently fails with:

SyntaxError: WorkerGlobalScope.importScripts: Failed to load worker script at "worker.js"

droogmic added 5 commits May 24, 2022 16:42

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
An attempt was made
@droogmic droogmic linked an issue May 29, 2022 that may be closed by this pull request
@droogmic
Copy link
Collaborator Author

This now works, but it depends on an upstream branch I don't control.

@droogmic droogmic marked this pull request as ready for review June 16, 2022 10:30
@droogmic droogmic mentioned this pull request Jun 16, 2022
Copy link
Contributor

@dabreegster dabreegster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to work nice and quickly locally, and the code isn't hard to follow! I guess the only concern was gloo-worker = { git = "https://github.com/futursolo/gloo", rev = "a2101e166260294292c8121fdb8ed883dae62ed8" }, right? Unless the branch is deleted, there shouldn't be any problems with reproducible builds.

Awesome work!

@@ -478,6 +478,31 @@ mod tests {
});
}

#[test]
fn test_json() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was motivated by tracking down where the serde flattening bug was happening, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, if you replace this with bincode, the test fails :)

@droogmic droogmic merged commit ab1c1da into a-b-street:main Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Web Worker
2 participants