-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
This now works, but it depends on an upstream branch I don't control. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to work nice and quickly locally, and the code isn't hard to follow! I guess the only concern was gloo-worker = { git = "https://github.com/futursolo/gloo", rev = "a2101e166260294292c8121fdb8ed883dae62ed8" }
, right? Unless the branch is deleted, there shouldn't be any problems with reproducible builds.
Awesome work!
@@ -478,6 +478,31 @@ mod tests { | |||
}); | |||
} | |||
|
|||
#[test] | |||
fn test_json() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was motivated by tracking down where the serde flattening bug was happening, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, if you replace this with bincode, the test fails :)
This currently fails with: