On the web, load different maps by making asynchronous HTTP calls. #21 #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelkirk
reviewed
Oct 8, 2020
game/run_web.sh
Outdated
| @@ -4,4 +4,6 @@ set -e | |||
| wasm-pack build --dev --target web -- --no-default-features --features wasm | |||
| cp index.html pkg | |||
| cd pkg | |||
| rm -f system | |||
| ln -s ../../data/system/ . | |||
There was a problem hiding this comment.
alternatively you could have the webroot checked in with a symlink. I'm a little nervous about a script which deletes files - especially when they don't enforce what directory you're currently in.
There was a problem hiding this comment.
Good call, done. wasm-pack sticks a .gitignore in pkg/, but turns out you can delete it, add the symlinks, then let the gitignore file come back, and it all seems to work.
michaelkirk
approved these changes
Oct 8, 2020
This is a very strange, specializd approach; it's unclear how it'll generalize to reading scenarios and prebaked results. Ideally we could call abstutil::read_binary as we currently do and somehow hide this async trickery underneath, but I'm not sure how yet. In the meantime, this moves us forward with the hack well-contained. Next steps for web: stop bundling in all of data/system in the .wasm, now that we can load from HTTP.
dabreegster
force-pushed
the
web_load_map
branch
from
c638832
to
455ba83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very strange, specializd approach; it's unclear how it'll
generalize to reading scenarios and prebaked results. Ideally we could
call abstutil::read_binary as we currently do and somehow hide this async
trickery underneath, but I'm not sure how yet. In the meantime, this
moves us forward with the hack well-contained.
Next steps for web: stop bundling in all of data/system in the .wasm,
now that we can load from HTTP.
@michaelkirk