modifiers: support nesting #698
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slightly reformat the NOTIFICATION_LOCAL_TRANSFORM_CHANGED handler inside voxel_modifier_gd. This will allow for my next commit to be slightly cleaner. Signed-off-by: NTOP <[email protected]>
Ignore transform update notifications that do not actually alter the modifier's position in terrain-local space. Support modifiers as indirect children. Switch to ENTER/EXIT_TREE notifications to detect when intermediate ancestors are added or removed from the terrain node. Switch to NOTIFICATION_TRANSFORM_CHANGED to detect when intermediate ancestor transforms change. Signed-off-by: NTOP <[email protected]>
Multiply modifier bounds transforms by the terrain parent_transform so that modifier are correctly rendered when the voxel terrain has non-identity transform. Signed-off-by: NTOP <[email protected]>
|
One thing I notice off the bat is that I did not implement this in my version: void VoxelModifier::mark_as_immediate_child(bool v) {
} break;
_is_immediate_child = v;
if (_is_immediate_child) {
set_notify_local_transform(true);
set_notify_transform(false);
} else {
set_notify_local_transform(false);
set_notify_transform(true);
}
}I considered doing something essentially identical, but I decided that the performance gains (which if I am not mistaken aren't much?) were not worth cluttering the solution. Please let me know if you disagree with that judgement, though! |
|
That also appears to be the only substantive difference between our two PRs, other than a totally different approach to event handling |
|
I'm still not happy with the workarounds that Godot requires to make this work, it always makes it more expensive too. Just like the other PR, I'm not sure about merging this. |
Zylann
force-pushed
the
master
branch
2 times, most recently
from
8fdf450
to
a393969
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves/adds support for nested modifier structures in the voxel lod terrain tree.
These changes are not of particular importance to me (other than the ability to filter out terrain translation). I just happened to be in the area and noticed your TODO comment, and I thought this might be a good place to cut my teeth.