Skip to content
This repository has been archived by the owner on Aug 5, 2024. It is now read-only.

fix: compose store #52

Merged
merged 4 commits into from
Dec 13, 2022
Merged

fix: compose store #52

merged 4 commits into from
Dec 13, 2022

Conversation

Tiagoperes
Copy link
Contributor

@Tiagoperes Tiagoperes commented Dec 13, 2022 •
edited
Loading

  • To avoid unnecessary processing and memory consumption, childrenAsList in ComponentData is now a function.
  • Prevented possible unnecessary recomposition on NodeFlow where the children was initialized with an empty list and then updated with the actual children. Now the state is initialized with the actual children.
  • Centralized the Loading component in the screen.

@Tiagoperes Tiagoperes marked this pull request as draft December 13, 2022 13:11
@Tiagoperes Tiagoperes mentioned this pull request Dec 13, 2022
Merged
@Tiagoperes Tiagoperes marked this pull request as ready for review December 13, 2022 18:16
@Tiagoperes Tiagoperes merged commit 9aa7569 into main Dec 13, 2022
@Tiagoperes Tiagoperes deleted the fix/compose-store branch December 13, 2022 20:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hernandazevedozup hernandazevedozup hernandazevedozup approved these changes

@arthurbleilzup arthurbleilzup Awaiting requested review from arthurbleilzup arthurbleilzup is a code owner

@dantes-git dantes-git Awaiting requested review from dantes-git

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tiagoperes @hernandazevedozup