self review

ZupIT · Dec 13, 2022 · 2ac3f7f · 2ac3f7f
1 parent edef2bd
commit 2ac3f7f
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 11 deletions.
diff --git a/compose/src/main/java/br/com/zup/nimbus/compose/internal/NimbusNavigationExtensions.kt b/compose/src/main/java/br/com/zup/nimbus/compose/internal/NimbusNavigationExtensions.kt
@@ -17,9 +17,6 @@
 package br.com.zup.nimbus.compose.internal
 
 import androidx.compose.runtime.Composable
-import androidx.compose.runtime.LaunchedEffect
-import androidx.compose.runtime.mutableStateOf
-import androidx.compose.runtime.remember
 import androidx.navigation.NavBackStackEntry
 import androidx.navigation.NavHostController
 import br.com.zup.nimbus.compose.ErrorHandler

diff --git a/compose/src/main/java/br/com/zup/nimbus/compose/internal/NodeFlow.kt b/compose/src/main/java/br/com/zup/nimbus/compose/internal/NodeFlow.kt
@@ -16,18 +16,15 @@
 
 package br.com.zup.nimbus.compose.internal
 
-import android.util.Log
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.State
 import androidx.compose.runtime.collectAsState
 import br.com.zup.nimbus.compose.CoroutineDispatcherLib
 import br.com.zup.nimbus.core.dependency.Dependent
 import br.com.zup.nimbus.core.tree.ServerDrivenNode
 import kotlinx.coroutines.CoroutineScope
-import kotlinx.coroutines.ExecutorCoroutineDispatcher
 import kotlinx.coroutines.flow.MutableStateFlow
 import kotlinx.coroutines.launch
-import kotlinx.coroutines.newSingleThreadContext
 
 class NodeState(
     private val node: ServerDrivenNode,
@@ -37,11 +34,9 @@ class NodeState(
     operator fun component2() = children
 }
 
-class NodeFlow(
-    private val node: ServerDrivenNode,
-    private val scope: CoroutineScope = CoroutineScope(CoroutineDispatcherLib.backgroundPool)
-): Dependent {
+class NodeFlow(private val node: ServerDrivenNode): Dependent {
     private var memoizedChildren: MutableMap<String, NodeFlow> = mutableMapOf()
+    private val scope = CoroutineScope(CoroutineDispatcherLib.backgroundPool)
     private val current = MutableStateFlow(NodeState(node, calculateChildren()))
     val id: String get() = node.id
 

diff --git a/compose/src/main/java/br/com/zup/nimbus/compose/model/Page.kt b/compose/src/main/java/br/com/zup/nimbus/compose/model/Page.kt
@@ -16,7 +16,6 @@
 
 package br.com.zup.nimbus.compose.model
 
-import android.util.Log
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.collectAsState
 import androidx.compose.runtime.getValue