Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

feat: Adds jacoco #1621

Merged
merged 16 commits into from
Jun 14, 2021
Merged

feat: Adds jacoco #1621

merged 16 commits into from
Jun 14, 2021

Conversation

hernandazevedozup
Copy link
Contributor

@hernandazevedozup hernandazevedozup commented Jun 9, 2021 •
edited
Loading

Related Issues

Description and Example

Adding code coverage reports for android/backend provided by jacoco

Checklist

Please, check if these important points are met using [x]:

  • I read the PR Guide and followed the process outlined there for submitting this PR.
  • I avoided breaking changes by not changing public APIs that people rely on.
  • I am willing to follow-up on review comments in a timely manner.
  • I have made the documentation changes or I created an issue explaining how to document this change on Docs issues. Please link the issue here:

@hernandazevedozup
✨ Adds jacoco
d70eb42 
Signed-off-by: Hernand Azevedo <[email protected]>
@hernandazevedozup hernandazevedozup marked this pull request as draft June 9, 2021 17:41
@botbeaglezup botbeaglezup added android This issue directly affects structure and logic of Android project backend This issue directly affects structure and logic of Backend project CI/CD Something associated with continuous integration or deployment, pipeline automation labels Jun 9, 2021
igorgiumellizup
igorgiumellizup reviewed Jun 9, 2021
View reviewed changes
Copy link
Contributor

@igorgiumellizup igorgiumellizup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

hernandazevedozup
hernandazevedozup commented Jun 10, 2021
View reviewed changes
backend/processor/build.gradle Outdated
@@ -17,6 +17,7 @@
import br.com.zup.beagle.Dependencies

apply plugin: 'kotlin-kapt'
apply from: rootProject.file('../jacoco.gradle')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we want to change the default way to import the files, we can make this on a PR to change all the other implementations also. Some code below its alredy using this pattern.

@hernandazevedozup hernandazevedozup marked this pull request as ready for review June 11, 2021 15:09
@igorgiumellizup igorgiumellizup self-requested a review June 11, 2021 15:48
@hernandazevedozup hernandazevedozup marked this pull request as draft June 11, 2021 17:29
@hernandazevedozup
🔧 Adds jdk8 action
af7bf28 
Signed-off-by: Hernand Azevedo <[email protected]>
@hernandazevedozup
🔧 Adds jdk8 action
16ad4d3 
Signed-off-by: Hernand Azevedo <[email protected]>
@hernandazevedozup
🔧 Adds jdk8 action
9e28738 
Signed-off-by: Hernand Azevedo <[email protected]>
@hernandazevedozup
🔧 Fixing performance for tests
16a4c65 
Signed-off-by: Hernand Azevedo <[email protected]>
@hernandazevedozup
🔧 Fixing performance for tests
0e95fd1 
Signed-off-by: Hernand Azevedo <[email protected]>
@hernandazevedozup
🔧 Fixing performance for tests
c65c326 
Signed-off-by: Hernand Azevedo <[email protected]>
@hernandazevedozup
🔧 TESTING FALSE TEST
362569d 
Signed-off-by: Hernand Azevedo <[email protected]>
@hernandazevedozup
🔧 TESTING FALSE TEST
a3f60d7 
Signed-off-by: Hernand Azevedo <[email protected]>
@hernandazevedozup
🔧 Testing success
e51850a 
Signed-off-by: Hernand Azevedo <[email protected]>
@hernandazevedozup hernandazevedozup marked this pull request as ready for review June 11, 2021 19:59
uziasferreirazup
uziasferreirazup reviewed Jun 14, 2021
View reviewed changes
fastlane/Fastfile Outdated Show resolved Hide resolved
@hernandazevedozup
🔧 Rename coverage task
76ff59c 
Signed-off-by: Hernand Azevedo <[email protected]>
@hernandazevedozup
🔧 Rename coverage task
8344ddf 
Signed-off-by: Hernand Azevedo <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@hernandazevedozup hernandazevedozup merged commit 0bb271a into master Jun 14, 2021
@hernandazevedozup hernandazevedozup deleted the feature/jacoco branch June 14, 2021 15:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matheusribeirozup matheusribeirozup matheusribeirozup left review comments

@uziasferreirazup uziasferreirazup uziasferreirazup approved these changes

@LG95 LG95 LG95 approved these changes

@viniciusguardieirozup viniciusguardieirozup viniciusguardieirozup left review comments

@carlossteinzup carlossteinzup Awaiting requested review from carlossteinzup

@danilorochazup danilorochazup Awaiting requested review from danilorochazup

@dantes-git dantes-git Awaiting requested review from dantes-git

@gabrielleonardozup gabrielleonardozup Awaiting requested review from gabrielleonardozup

@hthemir hthemir Awaiting requested review from hthemir

@jefersonlopeszup jefersonlopeszup Awaiting requested review from jefersonlopeszup

@jenifersantoszup jenifersantoszup Awaiting requested review from jenifersantoszup

@joaoabreuzup joaoabreuzup Awaiting requested review from joaoabreuzup

@lucasaraujo lucasaraujo Awaiting requested review from lucasaraujo

@lucasfonsecazup lucasfonsecazup Awaiting requested review from lucasfonsecazup

@luisgustavozup luisgustavozup Awaiting requested review from luisgustavozup

@paulomeurerzup paulomeurerzup Awaiting requested review from paulomeurerzup

@tarcisiogc tarcisiogc Awaiting requested review from tarcisiogc

@theffc theffc Awaiting requested review from theffc

@Tiagoperes Tiagoperes Awaiting requested review from Tiagoperes

@tuliopereirazup tuliopereirazup Awaiting requested review from tuliopereirazup

@victorrabelozup victorrabelozup Awaiting requested review from victorrabelozup

@yandiaszup yandiaszup Awaiting requested review from yandiaszup

@ze12augusto ze12augusto Awaiting requested review from ze12augusto

@igorgiumellizup igorgiumellizup Awaiting requested review from igorgiumellizup

Assignees
No one assigned
Labels
android This issue directly affects structure and logic of Android project backend This issue directly affects structure and logic of Backend project CI/CD Something associated with continuous integration or deployment, pipeline automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hernandazevedozup @LG95 @matheusribeirozup @viniciusguardieirozup @uziasferreirazup @igorgiumellizup @botbeaglezup