Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

refactor: remove widgetView inheritance from PageIndicator component #1592

Merged
merged 3 commits into from
Jun 1, 2021
Merged

refactor: remove widgetView inheritance from PageIndicator component #1592

merged 3 commits into from
Jun 1, 2021

Conversation

luisoliveirazup
Copy link
Contributor

Related Issues

closes #1591

Description and Example

Remove widgetView inheritance from PageIndicator component:

Checklist

Please, check if these important points are met using [x]:

  • I read the PR Guide and followed the process outlined there for submitting this PR.
  • I avoided breaking changes by not changing public APIs that people rely on.
  • I am willing to follow-up on review comments in a timely manner.
  • I have made the documentation changes or I created an issue explaining how to document this change on Docs issues. Please link the issue here:

@luisoliveirazup luisoliveirazup added the android This issue directly affects structure and logic of Android project label May 31, 2021
@luisoliveirazup luisoliveirazup self-assigned this May 31, 2021
carlossteinzup
carlossteinzup previously approved these changes May 31, 2021
View reviewed changes
@luisoliveirazup luisoliveirazup marked this pull request as draft June 1, 2021 12:02
@luisoliveirazup luisoliveirazup marked this pull request as ready for review June 1, 2021 12:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@uziasferreirazup uziasferreirazup merged commit e5ecb2c into master Jun 1, 2021
@uziasferreirazup uziasferreirazup deleted the refactor/remove-widgetview-inheritance-pageview branch June 1, 2021 12:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uziasferreirazup uziasferreirazup uziasferreirazup approved these changes

@viniciusguardieirozup viniciusguardieirozup viniciusguardieirozup approved these changes

@matheusribeirozup matheusribeirozup matheusribeirozup approved these changes

@carlossteinzup carlossteinzup carlossteinzup left review comments

@danilorochazup danilorochazup Awaiting requested review from danilorochazup

@gabrielleonardozup gabrielleonardozup Awaiting requested review from gabrielleonardozup

@hernandazevedozup hernandazevedozup Awaiting requested review from hernandazevedozup

@hthemir hthemir Awaiting requested review from hthemir

@jefersonlopeszup jefersonlopeszup Awaiting requested review from jefersonlopeszup

@jenifersantoszup jenifersantoszup Awaiting requested review from jenifersantoszup

@paulomeurerzup paulomeurerzup Awaiting requested review from paulomeurerzup

@tarcisiogc tarcisiogc Awaiting requested review from tarcisiogc

@tuliopereirazup tuliopereirazup Awaiting requested review from tuliopereirazup

Assignees

@luisoliveirazup luisoliveirazup

Labels
android This issue directly affects structure and logic of Android project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove widgetView inheritance from PageIndicator component
5 participants
@luisoliveirazup @matheusribeirozup @viniciusguardieirozup @carlossteinzup @uziasferreirazup