Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

feat: Adds support to beagle gRPC library #1497

Merged
merged 11 commits into from
Apr 23, 2021
Merged

feat: Adds support to beagle gRPC library #1497

merged 11 commits into from
Apr 23, 2021

Conversation

paulomeurerzup
Copy link
Contributor

Adds support to beagle gRPC library.

Checklist

Please, check if these important points are met using [x]:

  • I read the PR Guide and followed the process outlined there for submitting this PR.
  • I avoided breaking changes by not changing public APIs that people rely on.
  • I am willing to follow-up on review comments in a timely manner.

@paulomeurerzup
feat: Add gRPC support for android
936cc08 
Signed-off-by: paulomeurerzup <[email protected]>
@paulomeurerzup
Add clientInterceptor
14d43c3 
Signed-off-by: paulomeurerzup <[email protected]>
@paulomeurerzup
refactor
bb4fee1 
Signed-off-by: paulomeurerzup <[email protected]>
@paulomeurerzup
refactor: Add tests
54beeac 
Signed-off-by: paulomeurerzup <[email protected]>
@paulomeurerzup
add HttpClient to beagleSDK
7f3c417 
Signed-off-by: paulomeurerzup <[email protected]>
@paulomeurerzup
apply changes to use beagle 1.6.0 version
7675db9 
Signed-off-by: paulomeurerzup <[email protected]>
@paulomeurerzup
removed local grpc library
3a56ba6 
Signed-off-by: paulomeurerzup <[email protected]>
@paulomeurerzup
removed test code
bf61649 
Signed-off-by: paulomeurerzup <[email protected]>
@github-actions github-actions bot added the android This issue directly affects structure and logic of Android project label Apr 19, 2021
@paulomeurerzup
adjust indentation
35446b8 
Signed-off-by: paulomeurerzup <[email protected]>
@paulomeurerzup paulomeurerzup marked this pull request as draft April 19, 2021 17:49
@paulomeurerzup
refactor: adjust tests
3925a33 
Signed-off-by: paulomeurerzup <[email protected]>
@paulomeurerzup paulomeurerzup self-assigned this Apr 22, 2021
@paulomeurerzup paulomeurerzup marked this pull request as ready for review April 22, 2021 17:37
@matheusribeirozup
Copy link
Contributor

Maybe the httpClient property in BeagleSdk should be deprecated.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
33.6% 33.6% Duplication

Tiagoperes
Tiagoperes approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@Tiagoperes Tiagoperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update both the BeagleDefaults project and the documentation with this change.

@Tiagoperes Tiagoperes merged commit b02b37c into master Apr 23, 2021
@Tiagoperes Tiagoperes deleted the feat/android/grpc branch April 23, 2021 12:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@botbeaglezup botbeaglezup botbeaglezup left review comments

@matheusribeirozup matheusribeirozup matheusribeirozup approved these changes

@Tiagoperes Tiagoperes Tiagoperes approved these changes

@carlossteinzup carlossteinzup Awaiting requested review from carlossteinzup

@danilorochazup danilorochazup Awaiting requested review from danilorochazup

@gabrielleonardozup gabrielleonardozup Awaiting requested review from gabrielleonardozup

@hernandazevedozup hernandazevedozup Awaiting requested review from hernandazevedozup

@hthemir hthemir Awaiting requested review from hthemir

@jefersonlopeszup jefersonlopeszup Awaiting requested review from jefersonlopeszup

@jenifersantoszup jenifersantoszup Awaiting requested review from jenifersantoszup

@luisoliveirazup luisoliveirazup Awaiting requested review from luisoliveirazup

@tarcisiogc tarcisiogc Awaiting requested review from tarcisiogc

@tuliopereirazup tuliopereirazup Awaiting requested review from tuliopereirazup

@uziasferreirazup uziasferreirazup Awaiting requested review from uziasferreirazup

@viniciusguardieirozup viniciusguardieirozup Awaiting requested review from viniciusguardieirozup

Assignees

@paulomeurerzup paulomeurerzup

Labels
android This issue directly affects structure and logic of Android project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulomeurerzup @matheusribeirozup @Tiagoperes @botbeaglezup