Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

fix: RecyclerView id access from ListView #1489

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Conversation

matheusribeirozup
Copy link
Contributor

Signed-off-by: Matheus Ribeiro [email protected]

Related Issues

Fixes #1473

Description and Example

When the dataSource of a ListView was informed together with the component, there was a crash on Android due to the synchronization of component ids with the view. To cover this scenario, an integrated test was changed, since all tests set the dataSource through the evaluation of a context and none were set directly.

Checklist

Please, check if these important points are met using [x]:

  • I read the PR Guide and followed the process outlined there for submitting this PR.
  • I avoided breaking changes by not changing public APIs that people rely on.
  • I am willing to follow-up on review comments in a timely manner.

@matheusribeirozup matheusribeirozup added bug Something isn't working android This issue directly affects structure and logic of Android project backend This issue directly affects structure and logic of Backend project tests labels Apr 14, 2021
@matheusribeirozup matheusribeirozup self-assigned this Apr 14, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@paulomeurerzup paulomeurerzup merged commit 12b533c into master Apr 15, 2021
@paulomeurerzup paulomeurerzup deleted the fix/list-view branch April 15, 2021 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
android This issue directly affects structure and logic of Android project backend This issue directly affects structure and logic of Backend project bug Something isn't working tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simple list view example will crash on Android
4 participants