Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

fix: image downloader test #1483

Merged
merged 1 commit into from
Apr 12, 2021
Merged

fix: image downloader test #1483

merged 1 commit into from
Apr 12, 2021

Conversation

matheusribeirozup
Copy link
Contributor

Signed-off-by: Matheus Ribeiro [email protected]

Related Issues

This PR fixes an error in the url used in the ImageDownloader unit test.

Description and Example

The unit test should not actually download the image, so it was replaced by a mock.

Checklist

Please, check if these important points are met using [x]:

  • I read the PR Guide and followed the process outlined there for submitting this PR.
  • I avoided breaking changes by not changing public APIs that people rely on.
  • I am willing to follow-up on review comments in a timely manner.

Signed-off-by: Matheus Ribeiro <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@paulomeurerzup paulomeurerzup merged commit fbac822 into master Apr 12, 2021
@paulomeurerzup paulomeurerzup deleted the fix/android-test branch April 12, 2021 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
android This issue directly affects structure and logic of Android project bug Something isn't working tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants