This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
fix: make unowned references weak #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasaraujo
added
the
iOS
Generated by 🚫 Danger |
lucasaraujo
force-pushed
the
ios/unowned-to-weak
branch
from
34837b0 to
7aa8455
Compare
theffc
reviewed
Mar 18, 2021
iOS/Sources/Beagle/Sources/Components/ServerDrivenComponent/Form/Form+Extensions.swift
Outdated
Show resolved
Hide resolved
iOS/Sources/Beagle/Sources/Components/ServerDrivenComponent/Lazy/LazyComponent+Extensions.swift
Outdated
Show resolved
Hide resolved
iOS/Sources/Beagle/Sources/Components/ServerDrivenComponent/Lazy/LazyComponent+Extensions.swift
Outdated
Show resolved
Hide resolved
iOS/Sources/Beagle/Sources/Components/ServerDrivenComponent/Lazy/LazyComponent+Extensions.swift
Outdated
Show resolved
Hide resolved
iOS/Sources/Beagle/Sources/Components/Widget/Button/Button+Extensions.swift
Outdated
Show resolved
Hide resolved
iOS/Sources/Beagle/Sources/Renderer/BeagleScreenViewController.swift
Outdated
Show resolved
Hide resolved
iOS/Sources/Beagle/Sources/Components/ServerDrivenComponent/TabBar/TabBarItemUIComponent.swift
Outdated
Show resolved
Hide resolved
lucasaraujo
force-pushed
the
ios/unowned-to-weak
branch
from
7aa8455 to
8f08420
Compare
lucasaraujo
force-pushed
the
ios/unowned-to-weak
branch
from
8f08420 to
cfc11d2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
lucasaraujo
requested review from
dantes-git,
gabcoelho,
joaoabreuzup,
lucasfonsecazup,
luisgustavozup,
tarcisiogc,
victorrabelozup and
yandiaszup
as code owners
dantes-git
approved these changes
Mar 22, 2021
luisgustavozup
approved these changes
Mar 22, 2021
theffc
approved these changes
Mar 23, 2021
dantes-git
pushed a commit
that referenced
this pull request
Mar 23, 2021
BREAKING CHANGE: the property controller in BeagleRenderer is now weak
uziasferreirazup
pushed a commit
that referenced
this pull request
Mar 24, 2021
uziasferreirazup
added a commit
that referenced
this pull request
Mar 29, 2021
* test components * feat: improve api to write flex and style * adjust code * remove components * add new components * create extension to unit value * adjust backend code and create sized box component * add new function in style * adjust operation * create static function in bind * improve accessbility * create helper to platform * apply var to corner radius * adjust code * add simple documentation * adjust documentation * adjust code * create unit test * create unit test * adjust code * create unit test * adjust test and components * adjust expanded * fix: PageView retain cycle (#1434) * Fix PageView retain cycle * PageView retain cycle test * chore: adjust error in horusec (#1441) * chore: ignore error in appium test * adjust * adjust * fix page layout of listView tests (#1423) * feat: Improve iOS test script setup step (#1429) * update * update * update * update * update * update * update * update * update * update * update * update * update * update * update * update * Update automated_tests_appium_ios.yml update * Update backend/framework/src/main/kotlin/br/com/zup/beagle/platform/BeaglePlatform.kt Co-authored-by: igorgiumellizup <[email protected]> * Update backend/kotlin-core/src/main/kotlin/br/com/zup/beagle/ext/FlexExtension.kt Co-authored-by: igorgiumellizup <[email protected]> * Update backend/kotlin-core/src/main/kotlin/br/com/zup/beagle/ext/FlexExtension.kt Co-authored-by: igorgiumellizup <[email protected]> * Update backend/kotlin-core/src/main/kotlin/br/com/zup/beagle/ext/FlexExtension.kt Co-authored-by: igorgiumellizup <[email protected]> * Update backend/kotlin-core/src/main/kotlin/br/com/zup/beagle/ext/StyleExtension.kt Co-authored-by: igorgiumellizup <[email protected]> * Update backend/kotlin-core/src/main/kotlin/br/com/zup/beagle/ext/StyleExtension.kt Co-authored-by: igorgiumellizup <[email protected]> * Update backend/widgets/src/main/kotlin/br/com/zup/beagle/widget/style/Margin.kt Co-authored-by: igorgiumellizup <[email protected]> * Update backend/widgets/src/main/kotlin/br/com/zup/beagle/widget/style/Padding.kt Co-authored-by: igorgiumellizup <[email protected]> * Update backend/widgets/src/main/kotlin/br/com/zup/beagle/widget/style/SizedBox.kt Co-authored-by: igorgiumellizup <[email protected]> * Update backend/widgets/src/main/kotlin/br/com/zup/beagle/widget/style/SizedBox.kt Co-authored-by: igorgiumellizup <[email protected]> * Update backend/widgets/src/main/kotlin/br/com/zup/beagle/widget/style/SizedBox.kt Co-authored-by: igorgiumellizup <[email protected]> * fix: iOS - TextInput enabled custom style config (#1440) * fix: iOS - ErrorView retry block (#1428) * fix: adjust crash when passing color in page indicator (#1452) * tests removal (#1448) * make unowned references weak (#1443) * Update backend/framework/src/main/kotlin/br/com/zup/beagle/platform/BeaglePlatform.kt Co-authored-by: Matheus Ribeiro Lima <[email protected]> * Update backend/framework/src/main/kotlin/br/com/zup/beagle/platform/BeaglePlatform.kt Co-authored-by: Matheus Ribeiro Lima <[email protected]> * Update backend/widgets/src/main/kotlin/br/com/zup/beagle/widget/style/Accessibility.kt Co-authored-by: Matheus Ribeiro Lima <[email protected]> * adjust style * adjust corner radius in platform * remove builders * adjust set flex * adjust name flexible * add new attribute has in master * Update backend/kotlin-core/src/main/kotlin/br/com/zup/beagle/ext/FlexExtension.kt Co-authored-by: paulomeurerzup <[email protected]> * Update backend/kotlin-core/src/main/kotlin/br/com/zup/beagle/ext/FlexExtension.kt Co-authored-by: paulomeurerzup <[email protected]> * adjust snapshot test Co-authored-by: Lucas Araújo <[email protected]> Co-authored-by: tayronemachadozup <[email protected]> Co-authored-by: igorgiumellizup <[email protected]> Co-authored-by: Daniel Tes <[email protected]> Co-authored-by: Matheus Ribeiro Lima <[email protected]> Co-authored-by: paulomeurerzup <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Example
Remove unowned references
Checklist