This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 89
docs: generating kdocs and uploading them #1391
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backend config
- Script Feedback
github-actions
bot
added
android
This issue directly affects structure and logic of Android project
backend
This issue directly affects structure and logic of Backend project
CI/CD
Something associated with continuous integration or deployment, pipeline automation
labels
Feb 25, 2021
vitorbassozup
changed the title
cd: dokka reference
docs: generating kdocs and uploading them
Feb 25, 2021
luismaximozup
previously approved these changes
Feb 25, 2021
LG95
reviewed
Feb 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are using some variables without double quotes, which makes your script fragile, breaking if a value becomes something with a space. https://github.com/koalaman/shellcheck/wiki/Sc2086 provides a great explication.
hernandazevedozup
previously approved these changes
Mar 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with suggestions
LG95
suggested changes
Mar 1, 2021
vitorbassozup
requested review from
adautopaulazup,
caioortu,
carlossteinzup,
danilorochazup,
dantes-git,
gabcoelho,
gabrielleonardozup,
hthemir,
jefersonlopeszup,
jenifersantoszup,
joaoabreuzup,
lucasaraujo,
lucasfonsecazup,
luisgustavozup,
luisoliveirazup,
matheusribeirozup,
paulomeurerzup,
tarcisiogc,
theffc,
Tiagoperes,
tuliopereirazup,
uziasferreirazup,
viniciusguardieirozup,
yandiaszup and
ze12augusto
as code owners
March 8, 2021 20:28
LG95
approved these changes
Mar 10, 2021
igorgiumellizup
approved these changes
Mar 17, 2021
uziasferreirazup
approved these changes
Mar 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
android
This issue directly affects structure and logic of Android project
backend
This issue directly affects structure and logic of Backend project
CI/CD
Something associated with continuous integration or deployment, pipeline automation
documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Example
This PR automatically generates and merges kdocs for backend and android projects and uploads it
Checklist
Please, check if these important points are met using
[x]
: