Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

docs: generating kdocs and uploading them #1391

Merged
merged 18 commits into from
Mar 25, 2021

Conversation

vitorbassozup
Copy link
Contributor

Description and Example

This PR automatically generates and merges kdocs for backend and android projects and uploads it

Checklist

Please, check if these important points are met using [x]:

  • I read the PR Guide and followed the process outlined there for submitting this PR.
  • I avoided breaking changes by not changing public APIs that people rely on.
  • I am willing to follow-up on review comments in a timely manner.

@vitorbassozup vitorbassozup self-assigned this Feb 25, 2021
@github-actions github-actions bot added android This issue directly affects structure and logic of Android project backend This issue directly affects structure and logic of Backend project CI/CD Something associated with continuous integration or deployment, pipeline automation labels Feb 25, 2021
@vitorbassozup vitorbassozup added the documentation Improvements or additions to documentation label Feb 25, 2021
@vitorbassozup vitorbassozup changed the title cd: dokka reference docs: generating kdocs and uploading them Feb 25, 2021
luismaximozup
luismaximozup previously approved these changes Feb 25, 2021
Copy link
Contributor

@LG95 LG95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are using some variables without double quotes, which makes your script fragile, breaking if a value becomes something with a space. https://github.com/koalaman/shellcheck/wiki/Sc2086 provides a great explication.

Copy link
Contributor

@hernandazevedozup hernandazevedozup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

fastlane/generateDocs.sh Outdated Show resolved Hide resolved
@uziasferreirazup uziasferreirazup merged commit 0fe3d65 into master Mar 25, 2021
@uziasferreirazup uziasferreirazup deleted the feature/dokka-reference branch March 25, 2021 16:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
android This issue directly affects structure and logic of Android project backend This issue directly affects structure and logic of Backend project CI/CD Something associated with continuous integration or deployment, pipeline automation documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants