This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
fixing lifecycle type #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tiagoperes
requested review from
carolinegoncalveszup,
leonardosantiagozup,
rafamsilva,
raphaelspimenta and
tarcisiogc
as code owners
leonardosantiagozup
approved these changes
Sep 4, 2020
carolinegoncalveszup
approved these changes
Sep 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Better typing for the lifecycle of the component TabView.
This was not necessary for the code to work. I did it because it's the only example we have of applying a lifecycle, and for this reason, I think it should be 100% correct.
- How I did it
Just changed the types.
- How to verify it
- Description for the changelog